Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple .dockerignore files naming convention for language mode #4059

Closed
thernstig opened this issue Sep 6, 2023 · 0 comments · Fixed by #4060
Closed

Support multiple .dockerignore files naming convention for language mode #4059

thernstig opened this issue Sep 6, 2023 · 0 comments · Fixed by #4060
Milestone

Comments

@thernstig
Copy link
Contributor

https://docs.docker.com/build/building/context/#dockerignore states:

If you use multiple Dockerfiles, you can use different ignore-files for each Dockerfile. You do so using a special naming convention for the ignore-files. Place your ignore-file in the same directory as the Dockerfile, and prefix the ignore-file with the name of the Dockerfile.
.
├── index.ts
├── src/
├── docker
│ ├── build.Dockerfile
│ ├── build.Dockerfile.dockerignore
│ ├── lint.Dockerfile
│ ├── lint.Dockerfile.dockerignore
│ ├── test.Dockerfile
│ └── test.Dockerfile.dockerignore

Thus

vscode-docker/package.json

Lines 1559 to 1561 in ab0c8e3

"filenames": [
".dockerignore"
]
should be amended to support this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants