Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep loading more than 10 minutes after clearing the invalid filter value #751

Closed
v-xuanzh opened this issue Jan 21, 2019 · 4 comments
Closed

Comments

@v-xuanzh
Copy link

OS: Windows
Node.js: V10.14.1
Extension Build: 20190120.1
Repro Steps:

  1. Create a build task 'taskhelloworld' according to https://docs.microsoft.com/en-us/azure/container-registry/container-registry-tutorial-quick-task.
  2. Right click the created task ->'Run Task' ->Make sure there generated a repository named 'helloworld' with images tagged as 'cj*'.
  3. Right click the task 'taskhelloworld' -> 'View Task Log' ->Input an invalid value on any of the text box of the filter like '' -> Press 'Enter'(It will pop up an error dialog--'Cannot read property 'os' of undefined').
  4. Clear the invalid value -> Press 'Enter' directly -> Check the result.

Expect:
Show all the images tagged as 'cj*' of the task 'taskhelloworld'.

Actual:

  1. Show all the images tagged as 'cj*' of the registry.
  2. Keep loading more than 10 minutes.
    image
@rosanch
Copy link
Contributor

rosanch commented Jan 24, 2019

The filter does not support any type of expressions. I will file this as a feature request.

@rosanch
Copy link
Contributor

rosanch commented Jan 24, 2019

Sorry, I see what you mean. The loading appears to take a while for some unhandled filter request scenarios.

Also, I created a new issue (#757) for the enhancement request.

@ejizba
Copy link
Contributor

ejizba commented Jun 7, 2019

Closing this as "wont-fix" since filters aren't supported in the new tree and tasks view

@ejizba ejizba closed this as completed Jun 7, 2019
@ejizba ejizba added the wontfix label Jun 7, 2019
@v-dantch
Copy link

Add the screenshot for it:
image

@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants