Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Jump to file" could behave more like the Edge developer tools in the browser #259

Closed
billie-spektor opened this issue Jan 24, 2021 · 3 comments · Fixed by #264
Closed
Assignees
Milestone

Comments

@billie-spektor
Copy link

billie-spektor commented Jan 24, 2021

When clicking on a style property in the styles pane of the extension, you jump to the corresponding CSS file. This is very nice, but I would suggest to align this click behaviour with the behaviour in the Edge devtools in the browser:

  • when clicking on a style property, don't jump to the file
  • when clicking on the filename, do jump to the file
  • when control-clicking on a selector, style property or value, do jump to the corresponding file and line

The reason for this suggestion is that I sometimes just want to alter a value and do some minor CSS tweaking on a related component, while working in the context of another component. I don't want to switch context to the related component, because I'm just temporarily trying some things out to see how it interacts with the component I'm working on. Therefore, I think it could be nice if the file-jumping is a bit more of an explicit user action (by only jumping to the file when the user clicks on the filename, or when CTRL is used).

@codepo8
Copy link
Contributor

codepo8 commented Jan 27, 2021

This should work when you have your files synced. As we don't have the sources tab like we have in the developer tools, I wonder where the link should go. I agree though that it shouldn't be a link if it doesn't go anywhere.

@mliao95 mliao95 self-assigned this Jan 28, 2021
@mliao95
Copy link

mliao95 commented Jan 28, 2021

Hi billie-spektor. After testing around, I can see your frustration with this behavior. I'll take a look and try implementing a better workflow for this. Thanks for filing this issue!

@mliao95 mliao95 added this to the 1.1.3 milestone Jan 29, 2021
@billie-spektor
Copy link
Author

Thanks :) The gif in the pull request looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants