Adding another Disable Rule Comment through VSCode's Quick FIx options causes the rules to be re-enabled #1248
Labels
bug
Issue identified by VS Code Team member as probable bug
help wanted
Issues identified as good community contribution opportunities
Problem Statement
If a disable rule comment has already present for a particular line, and when we add another disable rule comment through vscode's quick-fix option, a separate new comment is added below the previous one. This causes the previous rule to be re-enabled for the concerned line.
Similar behaviour happens when
eslint.codeAction.disableRuleComment.location
has been set tosameLine
. The new disable rule comment is appended to the existing disable rule comment present.Expected Behaviour
If there is any preexisting disable rule comment for any particular line and another rule is being disabled for that same line, instead of creating or appending the comment, only the rule should be appended to the existing disable rule comment, separated by comma(s). Like this:
The same behavior is observed when disabling multiple rules for entire files as well, but it doesn't cause any rule to be re-enabled
I would like to work on the fix for this too.
The text was updated successfully, but these errors were encountered: