Server is sending diagnostics without a character field

[ram02z]

I'd like to preface that I am using the server packaged in https://github.com/hrsh7th/vscode-langservers-extracted. However, I thought this might still be an issue since the Neovim development team has said that LSPs should specify a column in their diagnostics.

Reference:
neovim/neovim#16673 (comment)
neovim/neovim#16675

[dbaeumer]

@ram02z can you please provide me with the example code where this is happending since the npm ESLint module should have never generated this and I would like to forward the issue to the ESLint team.

[dbaeumer]

And I actually sanitize missing values to zero here:

vscode-eslint/server/src/eslintServer.ts

Line 600 in 7568b4c

const startLine = Is.nullOrUndefined(problem.line) ? 0 : Math.max(0, problem.line - 1);

So I would really like to understand why this is happening.

[ram02z]

@dbaeumer sure.

Here is the file: https://gist.github.com/ram02z/e85910e6b8aa1044637607c5c950f595

Here are the neovim lsp logs that have a missing column: https://gist.github.com/ram02z/b11a3bbd53211d0199a13b32ad1e7a81

[dbaeumer]

@ram02z thanks for the file. But it is not enough to reproduce this. It looks like it depends on some configuration files / plugins / eslint version. Can you provide me with a GitHub repository I can clone that demos this?

[ram02z]

@dbaeumer You were right about the error depending on configuration/plugins.

Seems like the eslint-plugin-jsdoc plugin was causing the issue when the file was opened with the following eslintrc.json file.

{
  "parserOptions": {
    "ecmaVersion": 12,
    "sourceType": "module"
  },
  "plugins": ["jsdoc"],
  "rules": {
    "jsdoc/valid-types": 1
  }
}

The ESLint version is 8.6.0

[dbaeumer]

Thanks, was able to reproduce. The problem is that the jsdoc extension sets the values to NaN which is of type number in JS.