Warning status bar color should not be hardcoded

[sapegin]

statusBarItem.color = 'yellow';

Now you can configure status bar color, so it’s possible to have bad contrast:

Not sure what would be the best fix there since there’s only one foreground option. Probably we can detect if we have light or dark status bar background and use different text colors.

[dbaeumer]

Agree.

@aeschli any advice which color to use here.

[aeschli]

@dbaeumer What does the color signal? Error/Warning?

[dbaeumer]

@aeschli attention. Both error or warning would be fine.

[aeschli]

https://github.com/Microsoft/vscode-docs/blob/vnext/docs/getstarted/theme-color-reference.md has all the colors (for 1.13).
I'd suggest using:

• statusBarItem.prominentBackground: Status Bar prominent items background color. Prominent items stand out from other Status Bar entries to indicate importance.

For error/warning we have:
editorWarning.foreground and editorError.foreground but they are tuned for the editor background and might not work well with the status bar.

[dbaeumer]

@aeschli thanks !

[Hirse]

Is this issue still relevant given that the StatusBarItem has an icon to indicate the status and the hardcoded color is gone?

[sapegin]

Looks good now!