Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Offer code mark styles and gutter marks #99

Closed
darkred opened this issue Jul 10, 2016 · 4 comments
Closed

[feature request] Offer code mark styles and gutter marks #99

darkred opened this issue Jul 10, 2016 · 4 comments

Comments

@darkred
Copy link
Contributor

darkred commented Jul 10, 2016

(Using VSCode 1.3.0 in win 10 x64 build 10586 with vscode-eslint extension 1.10.18).

Currently the code marks(for errors and warnings) appear only as squiggly underline (i.e. as spellchecker errors in browsers, e.g. Firefox, Chrome):
(the error is in red, and the warning is in green)
2016-07-11_020259

My suggestion is to offer more code mark styles (ideally the outline style, as it highlights the errors/warnings the best way -see below- ) and gutter marks :
(with the errors to be in red, and the warnings to be in yellow, as ESLint itself uses these colors - not green)
2016-07-11_020203
(here is another screenshot)

It's more easy to distinguish the errors this way.

Thank you


For reference SublimeLinter3 package offers five different code mark styles :

  • fill,
  • outline (the default style),
  • solid underline,
  • squiggly underline, and
  • stippled underline

and two types of gutter marks:

  • errors, and
  • warnings
@AndrewIngram
Copy link

I found myself searching around for a setting to enable this, I guess i've been heavily spoiled by Atom and Sublime. This is pretty important for me, because I find the squiggly lines to be far too difficult to see when scrolling through a file.

@glebec
Copy link

glebec commented Jul 11, 2016

I second the use of yellow for warning. For one thing, red-green is always a poor UI choice as it ignores the 7%+ of XY-chromosomal people who have red-green color blindness. For another, it matches ESLint. Also yellow just feels more like a warning than green, culturally speaking.

Also, the gutter marks can be very helpful, though in the case of VSC it might require some different style as VSC's breakpoint markers are very similar to SublimeLinter error marks.

@dbaeumer
Copy link
Member

Moving to vscode since such a feature has to be implemented in the editor.

@dbaeumer
Copy link
Member

This issue was moved to microsoft/vscode#9209

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants