Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stuck in Saving 'foo.vue' Getting code actions from 'ESlint' or 'Vetur' #999

Closed
LiuLiTheRiver opened this issue Jun 22, 2020 · 10 comments
Closed
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@LiuLiTheRiver
Copy link

  • VSCode Version:1.46.1
  • OS Version:Windows_NT x64 10.0.18362

Steps to Reproduce:

1.Write a self close tag, eslint will make tag self close
<router-link></router-link>
gonna be :
<router-link />
2.Make the tag split and insert value
<router-link>foo</router-link>
3.Execute Save action then VSCode Stuck in Saving 'foo.vue' Getting code actions from 'ESlint'
4.
image

Does this issue occur when all extensions are disabled?: No

@jrieken jrieken assigned dbaeumer and unassigned jrieken Jun 22, 2020
@jrieken
Copy link
Member

jrieken commented Jun 22, 2020

adding @dbaeumer for why ESLint is soo slow

@dbaeumer
Copy link
Member

@liumt1993 since this very likely depends on ESLint version and Vetur / vue setup can you please provide me with a GitHub repository I can clone that demos this?

@dbaeumer dbaeumer transferred this issue from microsoft/vscode Jun 23, 2020
@dbaeumer dbaeumer added the info-needed Issue requires more information from poster label Jun 23, 2020
@vscodebot vscodebot bot closed this as completed Jun 30, 2020
@vscodebot
Copy link

vscodebot bot commented Jun 30, 2020

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@rw251
Copy link

rw251 commented Jul 15, 2020

I also came across this. At the time I had:

eslint v4.19.1
dbaeumer.vscode-eslint v2.1.7

It only happened intermittently and upgrading to eslint v7 resolved the problem.

@LiuLiTheRiver
Copy link
Author

I also came across this. At the time I had:

eslint v4.19.1
dbaeumer.vscode-eslint v2.1.7

It only happened intermittently and upgrading to eslint v7 resolved the problem.

I'll try it, and i found this issue it's not intermittently.There is a problem when you make the self-close tag to split, even make the tag self close again, there still have this problem.

@dbaeumer
Copy link
Member

I need a GitHub repository that demos the problem to investigate. If not provided our bot closes issues automatically to keep the number manageable.

@heemoe
Copy link

heemoe commented Aug 6, 2020

same here

Saving 'invitation.ts': Getting code actions from ''ESLint', 'TypeScript and JavaScript Language Features''

image

vscode infomations:

Version: 1.47.3
Commit: 91899dcef7b8110878ea59626991a18c8a6a1b3e
Date: 2020-07-23T13:08:29.692Z
Electron: 7.3.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.4.0

image

it seems come from the latest version of vscode.

@dbaeumer
Copy link
Member

dbaeumer commented Aug 6, 2020

Actually the high CPU load is in the extension host not in the ESLint server (which would actually do the computation of the code actions). @heemoe can your reproduce this and could you share the repository?

@heemoe
Copy link

heemoe commented Aug 7, 2020

Actually the high CPU load is in the extension host not in the ESLint server (which would actually do the computation of the code actions). @heemoe can your reproduce this and could you share the repository?

It seems fixed after add editor.codeActionsOnSave

Here is some related settings

"editor.codeActionsOnSave": {
    "source.fixAll": true
  },
  "[vue]": {
    "editor.defaultFormatter": "octref.vetur"
  },
  "[typescript]": {
    "editor.defaultFormatter": "vscode.typescript-language-features"
  },
  "[json]": {
    "editor.defaultFormatter": "vscode.json-language-features"
  },
  "[html]": {
    "editor.defaultFormatter": "vscode.html-language-features"
  },
  "[javascript]": {
    "editor.defaultFormatter": "vscode.typescript-language-features"
  },
  "editor.formatOnSave": true

@itsalb3rt
Copy link

I made a risky decision and deleted the line.

"editor.codeActionsOnSave": {
    "source.fixAll": true
  }

@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

6 participants