Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Typescript: At Issue #1027 #1044

Closed
wants to merge 2 commits into from

Conversation

meermustan
Copy link

  • Fixes the issue timeout has wrong type in decorator-sample #1027 that while compiling, Timer is Not assignable to parameter of type 'string', So Changes the NodeJs.Timer to NodeJs.Timeout
  • After that it's gives another compile error in library so in tscondig.json added flag to skipLibCheck
  • Now it's compiling successfully

 - Fixes the issue microsoft#1027 that while compiling, Timer is Not  assignable to parameter of type 'string', So Changes the NodeJs.Timer to NodeJs.Timeout
 - After that it's gives another compile error in library so in tscondig.json added flag to skipLibCheck
 - Now it's compiling successfully
@meermustan
Copy link
Author

npm install --save @walletconnect/client @walletconnect/qrcode-modal

Sorry didn't get it what it means to be? add some additional information! Thanks

@mjbvz
Copy link
Collaborator

mjbvz commented Jun 27, 2024

I believe this was fixed when I updated all the samples to TS 5.5. If there are still issues, please let me know and update this PR

@mjbvz mjbvz closed this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants