Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing Chat-Sample based application is broken with version 1.90 (non-insiders build) #1048

Closed
animeshj9 opened this issue Jun 10, 2024 · 12 comments
Assignees

Comments

@animeshj9
Copy link

Extension sample

chat-sample

VS Code version

1.90.0

What went wrong?

We had a working chat-sample based extension on v1.89.0 on the main version of VSCode. Updating VSCode to 1.90 breaks the sample. The '@' command does not show up anymore with version 1.90.0.

Additionally, we used to add "enable-proposed-api": <our_extension_id> to the users argsv.json file on the users vscode to automatically enable the proposed API after getting confirmation from the user. That flow is also broken now.

@DinahK-2SO
Copy link

DinahK-2SO commented Jun 11, 2024

To add more details, when developing extension on vscode v1.89.0, we added 2 proposed API files:
vscode.proposed.chatParticipant.d.ts, and vscode.proposed.languageModels.d.ts.

But the source files of these 2 proposed APIs are now unavailable:
https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.chatParticipant.d.ts
https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.languageModels.d.ts

Even if we kept these 2 source files in our code, they don't work any more after vscode upgraded from 1.89 to 1.90.

Are there new APIs for copilot chat in v1.90 ?

@DinahK-2SO
Copy link

Find a possible solution: adding "chatParticipantPrivate" into the "enabledApiProposals" in package.json for VSCode >= 1.90

@erlingto
Copy link

I'm also experiencing this issue. Does anyone know why the @participants have disappeared?

Is this feature not ready for publishing yet? I might have missed it, but the documentation doesn't clearly state that this feature is still in preview, if that's the case. Previously, the documentation mentioned to set a requirement for VSCode 1.90, which wasn't released yet and was only available through VSCode Insiders. I expected it to be available when 1.90 was released.

@bararchy
Copy link

It seemed to just go even more broken now with even insider giving errors... I hope someone is looking into that

@isidorn isidorn self-assigned this Jun 19, 2024
@isidorn
Copy link
Contributor

isidorn commented Jun 19, 2024

Sorry about the slow response here.

@erlingto @DinahK-2SO @animeshj9 can you reproduce your issue with VS Code Insiders? If not - it is expected for VS Code Stable to silently ignore the participant contributions until the next stable release (first week of July). I apologize if this was not communicated clearly.

@bararchy can you provide those errors you are seeing now? The chat sample works fine for me with latest insiders. Might you have been hitting this issue that is now fixed microsoft/vscode#216477

Also whenever you create an issue for Chat and Language Model APIs feel free to ping me @isidorn on it.
And I suggest always opening issues in https://github.com/microsoft/vscode/issues

@McNickSisto
Copy link

upgraded to 1.9 and now it says "No chat models available"

@isidorn
Copy link
Contributor

isidorn commented Jun 21, 2024

@McNickSisto are you on latest VS Code Insiders and latest Copilot Chat pre-release? If yes and you still see this, are you using the vanilla chat sample?
I just tried and it works for me.

@bararchy
Copy link

@isidorn yeha you were right, it seems my issue was indeed the one you linked to. Sorry about it

@isidorn
Copy link
Contributor

isidorn commented Jun 21, 2024

No worries. That was an unexpected breakage - sorry!

Let's see if there is an issue that @McNickSisto is facing. If not, I will go ahead and close this issue.

@McNickSisto
Copy link

@isidorn I checked again, I was in release version, i then switched to pre-release but I encountered the same error when calling the api.

image

using the following
const models = await vscode.lm.selectChatModels({ vendor: 'copilot', family: 'gpt-3.5-turbo' });

@McNickSisto
Copy link

McNickSisto commented Jun 21, 2024

@isidorn just realized I am not on VS Code Insiders, my bad. I should expect the changes to be ready by the first week of July then ?

@isidorn
Copy link
Contributor

isidorn commented Jun 21, 2024

Yes. Or you can use VS Code Insiders today.
I will go ahead and close this issue. Thanks!

@isidorn isidorn closed this as completed Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants