Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

graceful-fs@2 and @3 support will be removed soon #28

Closed
ChALkeR opened this issue Jul 24, 2016 · 2 comments
Closed

graceful-fs@2 and @3 support will be removed soon #28

ChALkeR opened this issue Jul 24, 2016 · 2 comments
Assignees

Comments

@ChALkeR
Copy link

ChALkeR commented Jul 24, 2016

Hi. vscode is currently #110 in my list of modules that would likely to be broken when nodejs/node#6413 lands (which is anticipated to happen before v7.0).

Note that graceful-fs@1 and graceful-fs@4 are ok and would not be broken by this, but a require() on graceful-fs@2 or graceful-fs@3 would cause an error soon.

That is, runtime warning fs: re-evaluating native module sources is not supported. would be turned into a throw.

If you or your deps use graceful-fs@2 or graceful-fs@3 in runtime — you are affected.

Tracking: nodejs/node#5213.

@bpasero bpasero assigned Tyriar and unassigned bpasero Sep 27, 2016
@bpasero
Copy link
Member

bpasero commented Sep 27, 2016

@Tyriar gulp-untar is old enough that it drags in a problematic graceful-fs version. Can we see if there is a newer replacement that does the same?

@Tyriar Tyriar added this to the October 2016 milestone Sep 27, 2016
@Tyriar
Copy link
Member

Tyriar commented Oct 23, 2016

Put out PR jmerrifield/gulp-untar#7 to fix this in the module.

@Tyriar Tyriar modified the milestones: November 2016, October 2016 Oct 23, 2016
@Tyriar Tyriar closed this as completed in 725a99e Oct 24, 2016
@Tyriar Tyriar removed this from the November 2016 milestone Oct 24, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants