Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Enable multi-root set up #1142

Closed
6 tasks done
ramya-rao-a opened this issue Aug 13, 2017 · 1 comment
Closed
6 tasks done

Enable multi-root set up #1142

ramya-rao-a opened this issue Aug 13, 2017 · 1 comment
Assignees

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Aug 13, 2017

  • 🏃 Mark all settings except language server related ones as scope = "resource". This is so that current workspace specific settings continue to work as folder specific settings in the multi-root set up
  • 🏃 Update all (except language-server related) the getConfiguration('go') calls to include resource uri for file open in current editor.
  • 🏃 Instead of updating process.env with the GOPATH, ensure the right GOPATH as per settings are used whenever a process is created to run the Go tools by updating the goToolsEnvVars()
  • 🏃 Replace use of vscode.workspace.rootPath with vscode.workspace.getWorkspaceFolder when there is an editor open.
  • If go.toolsGopath is not set in user/workspace settings, but it is set in one of the folders, then use it.
  • Use language server only if all the folders are using the same GOPATH

To keep things simple for now, all the "workspace" related commands and build/lint/vet/test on save for workspace will not cover all folders in multi-root. It will be restricted to current folder

@ramya-rao-a
Copy link
Contributor Author

Pending items

  • Merge to master
  • Another round of testing

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant