Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Prompts to update gopls as and when a new stable version is out #2776

Closed
ramya-rao-a opened this issue Sep 21, 2019 · 3 comments
Closed

Prompts to update gopls as and when a new stable version is out #2776

ramya-rao-a opened this issue Sep 21, 2019 · 3 comments

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Sep 21, 2019

In 0.11.5, we introduced a feature where the extension prompts users to update their gopls if it was found to be out of date when compared to the latest stable version.

This was done by making calls to https://proxy.golang.org

This approach has a couple of concerns

  • The call would fail for users behind corporate or private proxies or in China. See language server(gopls) not working #2768
  • Users might have their own GOPROXY set up in which case that is what should be respected
  • Some users might not want such outgoing calls and so would want a way to turn it off.

In 0.11.6, we are no longer making such outgoing calls and have instead hard-coded the currently known latest version of gopls in the check that results in the prompt to update gopls

This issue is to discuss next steps that will allow us to prompt users to update gopls as and when a new stable version is out while keeping the above concerns in mind

cc @stamblerre

@ramya-rao-a
Copy link
Contributor Author

Current proposals:

@stamblerre
Copy link
Contributor

I think the combination of the two current proposals will be sufficient to make sure that the user has enough control over the auto-updating behavior. The go command will make requests to GOPROXY when VSCode runs go get to install packages, so this will behave in a similar fashion. The setting adds another level of protection, so if a user doesn't want the auto-updating behavior, it can be turned off. This sounds pretty solid to me. What do you think, @ramya-rao-a?

@ramya-rao-a
Copy link
Contributor Author

ramya-rao-a commented Oct 21, 2019

The latest beta version of the extension has this feature where the GOPROXY is used to determine whether a newer update is available. This can be disabled using the new setting go.useGoProxyToCheckForToolUpdates

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants