Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Search for implementations doesn't work #2823

Closed
inliquid opened this issue Oct 9, 2019 · 6 comments
Closed

Search for implementations doesn't work #2823

inliquid opened this issue Oct 9, 2019 · 6 comments
Labels
upstream-gopls Issue for gopls

Comments

@inliquid
Copy link

inliquid commented Oct 9, 2019

  1. go1.13
  2. vscode-go 0.11.7
  3. gopls@master

Peek implementations Ctrl-Shift-F12 used. Ctrl-F12 has same result. There are 2 implementations of given service, however guru returns immediately:
изображение

@ramya-rao-a
Copy link
Contributor

Can you run the guru command with those exact arguments and see if it returns any results?

@inliquid
Copy link
Author

it returns exactly this:

guru: no packages specified for pointer analysis scope

@ramya-rao-a
Copy link
Contributor

Are you using modules? If yes, then we know that guru does not have module support yet.

@stamblerre Does the language server support the implementation provider yet?

@inliquid
Copy link
Author

@ramya-rao-a yes, with modules. It worked previously, I just didn't use often it because it's too slow. Not sure what changed now.

@stamblerre
Copy link
Contributor

stamblerre commented Oct 21, 2019

Are you using modules? If yes, then we know that guru does not have module support yet.

guru will not have module support and is not being actively developed.

@stamblerre Does the language server support the implementation provider yet?

gopls does not yet have the implementation feature, but it is something we intend to add support for soon (golang/go#32973).

@ramya-rao-a
Copy link
Contributor

Closing this issue in favor of the upstream issue linked above.

@ramya-rao-a ramya-rao-a added upstream-gopls Issue for gopls and removed needs more info labels Dec 15, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
upstream-gopls Issue for gopls
Projects
None yet
Development

No branches or pull requests

3 participants