Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow Bytes per Row > 32 #377

Open
TheSilverLaker opened this issue Aug 29, 2022 · 5 comments
Open

Feature Request: Allow Bytes per Row > 32 #377

TheSilverLaker opened this issue Aug 29, 2022 · 5 comments
Labels
feature request Issues related to new features users want UI/UX Issues regarding the UI or the UX of the extension

Comments

@TheSilverLaker
Copy link

Currently the option to control the number of bytes viewed per row has a limit of 32.
Unless there's a very specific reason for this limit it would be great if it could be increased (or even better made unlimited).

@zwenc
Copy link

zwenc commented Dec 1, 2022

Currently the option to control the number of bytes viewed per row has a limit of 32. Unless there's a very specific reason for this limit it would be great if it could be increased (or even better made unlimited).

Hello, I've found a way to solve this problem

  • Find the location where hex edit is installed on computer. The location on my computer is as follows: Users/UserName/.vscode/extensions/ms-vscode.hexeditor-1.9.9/dist
  • open editor.js
  • search "columnWidth:Math.min(i, 32)" and "columnWidth:Math,min:1,max:32"
  • change the 32 to 320 or which you want
  • restart vscode

the two position example are as follows, I have change it to 320:
1
2

now, it works
3

@lramos15 lramos15 added UI/UX Issues regarding the UI or the UX of the extension feature request Issues related to new features users want labels Dec 1, 2022
@lramos15
Copy link
Member

lramos15 commented Dec 1, 2022

I think this was originally added just because performance and rendering can be a bit slow when you have so much data on the screen at once. We can remove the cap or make it larger, but make no guarantees of the extension perf at that point

@zwenc
Copy link

zwenc commented Dec 2, 2022

I think this was originally added just because performance and rendering can be a bit slow when you have so much data on the screen at once. We can remove the cap or make it larger, but make no guarantees of the extension perf at that point

Thank you for your reply, I have some other suggestions.

  1. When we need to view a image's hex file, we need set the row size as image's width, so we need make it larger. however when I make it larger, the windows is too small to display it. so maybe add a bottom slider in the windows will be better.
  2. Now,The row size is global parameter for all windows. For example, When I change the row size in a window, the Other windows's row size will be changed too. This is not conducive to viewing pictures of different sizes. Therefore, I suggest that different windows use different row size.
  3. Now,The C/C++ use the hexedit as the default memory view, Could you add an automatic memory refresh function?

Thank you, hope you have a nice day!

@kevincrans
Copy link

kevincrans commented Jan 18, 2023

I at least expect it to support 128 wide.
Thank you for showing it is already possible, but I still expect this limitation to be removed.

@spatoa
Copy link

spatoa commented Sep 11, 2023

It seems the limit has been raised to a default of 512 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issues related to new features users want UI/UX Issues regarding the UI or the UX of the extension
Projects
None yet
Development

No branches or pull requests

5 participants