Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request] Add in data inspector ULEB128 and SLEB128 #485

Closed
jogo- opened this issue Feb 7, 2024 · 4 comments · Fixed by #488
Closed

[Feature request] Add in data inspector ULEB128 and SLEB128 #485

jogo- opened this issue Feb 7, 2024 · 4 comments · Fixed by #488
Labels
feature request Issues related to new features users want good first issue Good for newcomers help wanted Issues identified as good community contribution opportunities

Comments

@jogo-
Copy link
Contributor

jogo- commented Feb 7, 2024

Show in data inspector missing large integer formats as ULEB128 and LEB128 (Little Endian Base 128)
@connor4312 connor4312 added help wanted Issues identified as good community contribution opportunities good first issue Good for newcomers feature request Issues related to new features users want labels Feb 7, 2024
@jogo-
Copy link
Contributor Author

jogo- commented Feb 9, 2024

🤔 Maybe using WASM based Little Endian Base 128 varint encoding / decoding, supporting the full (u)int64 range https://github.com/thi-ng/umbrella/tree/develop/packages/leb128

@connor4312
Copy link
Member

It should be easy enough to implement in plain JS/TS, their wasm library is nothing magic

@jogo-
Copy link
Contributor Author

jogo- commented Feb 16, 2024

Decoding ULEB128 and LEB128 as a full 128 bit integers will be the biggest challenge, as the largest BigInt integer type is limited too.
Number.MAX_SAFE_INTEGER = 9007199254740991
Number.MIN_SAFE_INTEGER = -9007199254740991
Or I could try first to decode ULEB128 and LEB128 as sets of up to 16 bytes.
@connor4312 What is your opinion?

@connor4312
Copy link
Member

connor4312 commented Feb 16, 2024 •
edited
Loading

BigInt is an arbitrary precision integer type and is supported everywhere that VS Code runs

@jogo- jogo- changed the title [Feature request] Add in data inspector ULEB128 and LEB128 [Feature request] Add in data inspector ULEB128 and SLEB128 Feb 17, 2024
@jogo- jogo- mentioned this issue Feb 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Issues related to new features users want good first issue Good for newcomers help wanted Issues identified as good community contribution opportunities
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Display in data inspector ULEB128 and SLEB128 jogo-/vscode-hexeditor
2 participants
@connor4312 @jogo-