Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put the test message location to where it happens #1266

Closed
jdneo opened this issue Aug 6, 2021 · 4 comments · Fixed by #1323
Closed

Put the test message location to where it happens #1266

jdneo opened this issue Aug 6, 2021 · 4 comments · Fixed by #1323
Milestone

Comments

@jdneo
Copy link
Member

jdneo commented Aug 6, 2021

More specifically, if an assert fails, have the TestMessage's location of the assert match the location in the method for the given assert. Similarly if something triggers an exception, we could have a TestMessage for the exception in potentially even a different file - such as extract from the exception stack the location in testMethod() that resulted in the failure.

Originally posted by @TimWebb in #1162 (comment)

@TimWebb
Copy link

TimWebb commented Aug 6, 2021

@jdneo Your last two points make good sense, focusing on the assertion stack placement in the data model.

@abmpicoli
Copy link

abmpicoli commented Oct 21, 2021

Yes, this is a sore point. The score Visual Studio Code vs Eclipse was around 7 x 3 , but now it is around 7 x 6 because eclipse actually shows where an error happens, and Visual Studio Code doesn't.

@jdneo
Copy link
Member Author

jdneo commented Oct 25, 2021

Hi @TimWebb, @abmpicoli.

I just made a proposal for this issue: #1323. If you have time, could you take a look and see if this UX looks good to you?

@jdneo jdneo added this to the 0.33.0 milestone Nov 2, 2021
@jdneo
Copy link
Member Author

jdneo commented Nov 22, 2021

End game verification steps:

  1. Run a test case that will fail.
  2. Check the test message displayed at where the error happens instead of the method declaration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants