Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Explorer doesn't recognize test classes with '$' in their names #1364

Closed
Tracked by #889
testforstephen opened this issue Jan 24, 2022 · 1 comment · Fixed by #1366
Closed
Tracked by #889

Test Explorer doesn't recognize test classes with '$' in their names #1364

testforstephen opened this issue Jan 24, 2022 · 1 comment · Fixed by #1366
Labels
bug
Milestone
0.34.0

Comments

@testforstephen
Copy link
Contributor

test classes
@jdneo
Copy link
Member

jdneo commented Jan 24, 2022

The code here returns null when the type contains $:

vscode-java-test/java-extension/com.microsoft.java.test.plugin/src/main/java/com/microsoft/java/test/plugin/util/TestSearchUtils.java

Line 274 in 41e71f6

final ASTNode node = root.findDeclaringNode(type.getKey());

@jdneo jdneo added the bug label Jan 24, 2022
@jdneo jdneo added this to the 0.34.0 milestone Jan 25, 2022
@jdneo jdneo mentioned this issue Jan 25, 2022
Merged
@jdneo jdneo mentioned this issue Jan 25, 2022
Closed
35 tasks
@testforstephen testforstephen mentioned this issue Jan 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.34.0
Development

Successfully merging a pull request may close this issue.

fix: Should recognize test classes with '$' in their names microsoft/vscode-java-test
2 participants
@jdneo @testforstephen