Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the testController.ts #1636

Open
jdneo opened this issue Dec 7, 2023 · 0 comments
Open

Refactor the testController.ts #1636

jdneo opened this issue Dec 7, 2023 · 0 comments
Assignees
Labels
eng Debts for engineering

Comments

@jdneo
Copy link
Member

jdneo commented Dec 7, 2023

Currently the runTests() of testController.ts is too complicated. What's the meaning of IRunOption and IRunTestContext

Since the debugger's progress reporter api has released for years, we can assume the API is always available and simplify it.

option.progressReporter = option.progressReporter ?? progressProvider?.createProgressReporter(option.isDebug ? 'Debug Tests' : 'Run Tests');

@jdneo jdneo added the eng Debts for engineering label Dec 7, 2023
@jdneo jdneo self-assigned this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eng Debts for engineering
Projects
None yet
Development

No branches or pull requests

1 participant