Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Javscript Debug Terminal also when jsx files are opened #1039

Closed
rickstaa opened this issue Jun 18, 2021 · 2 comments
Closed

Show Javscript Debug Terminal also when jsx files are opened #1039

rickstaa opened this issue Jun 18, 2021 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality verified Verification succeeded
Milestone

Comments

@rickstaa
Copy link

rickstaa commented Jun 18, 2021

Describe the feature you'd like

Currently, in the debug tab, the Javascript Debug terminal option is only shown when a js file is opened. I think it would also be a nice addition to show it when a jsx file is opened (or give users the ability to enable this option). I added a gif to display the behaviour.

javascvript_debugger_behavoir

Additional info

I added the following to my settings.json in trying to get this behaviour to work:

"files.associations": {
    "*.jsx": "javascriptreact"
}
@rickstaa rickstaa added the feature-request Request for new features or functionality label Jun 18, 2021
@connor4312 connor4312 added this to the June 2021 milestone Jun 23, 2021
@connor4312 connor4312 added the verification-needed Verification of issue is requested label Jun 29, 2021
@connor4312
Copy link
Member

Please verify in nightly

@rchiodo rchiodo added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Jun 29, 2021
@rickstaa
Copy link
Author

rickstaa commented Jul 7, 2021

@connor4312 Verified in:

Version: 1.58.0-insider
Commit: 4c952751a88154ff4c375b1ca78293ab53a5792a
Date: 2021-07-06T21:30:49.113Z
Electron: 12.0.13
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: 8.9.255.25-electron.0
OS: Linux x64 5.8.0-59-generic

Thanks a lot for fixing this issue.

jen801 referenced this issue in microsoft/powerquery-language-services Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants