Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug adapter not respecting ValueFormat fields #1188

Closed
EricCornelson opened this issue Jan 27, 2022 · 3 comments
Closed

debug adapter not respecting ValueFormat fields #1188

EricCornelson opened this issue Jan 27, 2022 · 3 comments
Assignees
@connor4312
Labels
author-verification-requested Issues potentially verifiable by issue author feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
March 2022

Comments

@EricCornelson
Copy link
Contributor

When the IDE wants to display values in hexadecimal, it sets the hex field on the format field (in Evaluate request, StackTrace request, Variables request, etc.), but the debug adapter currently ignores this value.

image

Log File
visualstudio-js-debugger.txt
@EricCornelson EricCornelson added the bug Issue identified by VS Code Team member as probable bug label Jan 27, 2022
@connor4312 connor4312 added the feature-request Request for new features or functionality label Jan 27, 2022
@connor4312
Copy link
Member

I don't think this is something we ever supported, so marking it as a feature.

@connor4312 connor4312 removed the bug Issue identified by VS Code Team member as probable bug label Jan 27, 2022
@connor4312 connor4312 added this to the February 2022 milestone Jan 27, 2022
@connor4312 connor4312 modified the milestones: February 2022, March 2022 Feb 23, 2022
@rzhao271 rzhao271 added the verification-needed Verification of issue is requested label Mar 22, 2022
@hediet hediet added the author-verification-requested Issues potentially verifiable by issue author label Mar 23, 2022
@connor4312
Copy link
Member

@EricCornelson can you validate that this works?

@JacksonKearl
Copy link

JacksonKearl commented Mar 25, 2022 •
edited
Loading

Verified by changing https://github.com/microsoft/vscode/blob/188b1a51fe48a225c2a977e2b32c472b46845d36/src/vs/workbench/contrib/debug/browser/debugSession.ts#L591 to:

return this.raw.evaluate({ expression, frameId, context, format: { hex: true } });

The right value is shown, though I'd expect a 0x prefix?

image

@JacksonKearl JacksonKearl added the verified Verification succeeded label Mar 25, 2022
@JacksonKearl JacksonKearl mentioned this issue Mar 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connor4312 connor4312

Labels
author-verification-requested Issues potentially verifiable by issue author feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
March 2022
Development

No branches or pull requests
5 participants
@connor4312 @hediet @rzhao271 @JacksonKearl @EricCornelson