Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pwa-debug doesn't break for older version of node.js #133

Closed
weinand opened this issue Dec 3, 2019 · 5 comments
Closed

pwa-debug doesn't break for older version of node.js #133

weinand opened this issue Dec 3, 2019 · 5 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@weinand
Copy link

weinand commented Dec 3, 2019

testing microsoft/vscode#85984:

  • make sure to have a node manager like "nvm" installed
  • install node version "8.11.4"
  • use simple one liner program console.log('hello world');
  • set breakpoint on first line
  • use this launch config:
    {
      "type": "pwa-node",
      "request": "launch",
      "name": "hello",
      "program": "${workspaceFolder}/hello.js",
      "runtimeVersion": "8.11.4"
    },

Observe:
program doesn't stop on first line.

Adding a "debugger;" statement doesn't help either.

If you change the type attribute from "pwa-node" to "node" it works fine.

@connor4312
Copy link
Member

This is probably a duplicate of #79, which should be fixed in the today's build that runs at 8 AM PST.

@connor4312 connor4312 added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 3, 2019
@weinand
Copy link
Author

weinand commented Dec 3, 2019

I'm not sure that this is a dup. Debugger statements should always be hit because they don't require a breakpoint from being registered.

@roblourens
Copy link
Member

vscode-pwa only supports slightly newer node versions, I think due to using the experimental 'inspector' module. Not sure what the minimum is, I think the latest 8.x should work. We need to figure that out and handle it...

@roblourens roblourens reopened this Dec 3, 2019
@connor4312
Copy link
Member

May be #134 then

@roblourens
Copy link
Member

Yeah I think it's covered by that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

3 participants