support the noDebug flag

[captainsafia]

This issue occurs when debugging a Blazor WASM application using vscode-js-debug.

When executing Start without Debugging, the noDebug property is set in the launching configuration for the debug session.

However, the browser launches with debugging enabled (e.g. you can set breakpoints and it makes requests to our DebugProxy.)

Note: This happens with Chrome. I'll see if Edge has the same issue.

[connor4312]

It does; js-debug does not actually respect the noDebug flag yet

[captainsafia]

Got it -- thanks for the quick response.

[isidorn]

@connor4312 I see there is already an issue for noDebug support so I will not create an additional one.

[connor4312]

I'm not sure if there's a "specification" for how noDebug is supposed to work. In the commit I have just skipped enabling the debugger, runtime, and network domains on the target. This means users will still see the sessions tree on the left hand side, but won't hit breakpoints.

Actually, I will also keep the Runtime domain enabled which lets them see user scripts, console logs, and the repl.

[weinand]

@connor4312 the DAP spec is not very precise on noDebug:

If noDebug is true the launch request should launch the program without enabling debugging.

So what you are doing for js-debug makes perfect sense.