Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node processes no longer killed when stopping debugging #864

Closed
oliversalzburg opened this issue Nov 25, 2020 · 4 comments
Closed

Node processes no longer killed when stopping debugging #864

oliversalzburg opened this issue Nov 25, 2020 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@oliversalzburg
Copy link

Describe the bug
When stopping debugging a Node application in VSC, the Node processes will keep running.

To Reproduce
Steps to reproduce the behavior:

  1. Start a Node debugging process.
  2. End the session.

VS Code Version:
Version: 1.51.1 (user setup)
Commit: e5a624b788d92b8d34d1392e4c4d9789406efe8f
Date: 2020-11-10T23:34:32.027Z
Electron: 9.3.3
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Windows_NT x64 10.0.19042

Additional context
Probably broken by e14d78f
Related to #630

@oliversalzburg oliversalzburg added the bug Issue identified by VS Code Team member as probable bug label Nov 25, 2020
@connor4312
Copy link
Member

I cannot reproduce this, please collect logs files using the instructions in the issue template.

@connor4312 connor4312 added the info-needed Issue requires more information from poster label Nov 25, 2020
@oliversalzburg
Copy link
Author

I sent you an email with the log.

@oliversalzburg
Copy link
Author

Personally, I could only see one relevant entry in the log, the last line mentioning that killing the process failed. I didn't see anything helpful with more information.

If you want me to check anything specific or record other information, let me know.

@connor4312 connor4312 added this to the November 2020 milestone Dec 1, 2020
@connor4312 connor4312 removed the info-needed Issue requires more information from poster label Dec 1, 2020
@connor4312
Copy link
Member

Thanks, fixed in d08340a. Not sure why I didn't see this before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants