Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support forwarded port attributes #942

Closed
connor4312 opened this issue Mar 16, 2021 · 3 comments
Closed

Support forwarded port attributes #942

connor4312 opened this issue Mar 16, 2021 · 3 comments
Assignees
@connor4312
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
March 2021

Comments

@connor4312
Copy link
Member

See microsoft/vscode#115616
@connor4312 connor4312 added the feature-request Request for new features or functionality label Mar 16, 2021
@connor4312 connor4312 added this to the March 2021 milestone Mar 16, 2021
@connor4312 connor4312 self-assigned this Mar 16, 2021
@connor4312 connor4312 added the verification-needed Verification of issue is requested label Mar 16, 2021
@alexr00
Copy link
Member

alexr00 commented Mar 24, 2021

Is everything required to test this already available in JS Debug Nightly? I'm still seeing 3 ports get forwarded:

image

My steps:

  1. Connect to a container for microsoft/vscode-remote-try-node.
  2. Install ms-vscode.js-debug-nightly in the container and disable the built-in JS Debug extension.
  3. F5.

I debugged a bit, and the results I'm getting back from the portsAttributesProviders only show one port getting ignored:
image
I think that those other ports are known about by JS Debug. Can they also be ignored?

@alexr00 alexr00 added the verification-found Issue verification failed label Mar 24, 2021
@alexr00 alexr00 reopened this Mar 24, 2021
@connor4312
Copy link
Member Author

Thanks, fixed it!

@connor4312 connor4312 removed the verification-found Issue verification failed label Mar 24, 2021
@alexr00 alexr00 added the verified Verification succeeded label Mar 25, 2021
@alexr00
Copy link
Member

alexr00 commented Mar 25, 2021

Works beautifully!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connor4312 connor4312

Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
March 2021
Development

No branches or pull requests
2 participants
@connor4312 @alexr00