Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Immediate "Node version is outdated" notification on startup. #957

Closed
JacksonKearl opened this issue Mar 26, 2021 · 4 comments
Closed

Immediate "Node version is outdated" notification on startup. #957

JacksonKearl opened this issue Mar 26, 2021 · 4 comments
Assignees
@connor4312
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
April 2021

Comments

@JacksonKearl
Copy link

Version 1.54.2

Start vscode to empty workbench with a system node on 6 (I was testing some stuff 🙃). Immediately get this notification:
image

It'd be better if this only showed when someone actually tries to debug.
@JacksonKearl JacksonKearl added the bug Issue identified by VS Code Team member as probable bug label Mar 26, 2021
@connor4312
Copy link
Member

Do you have auto attach on? If so, this is as intended.

@connor4312 connor4312 added the info-needed Issue requires more information from poster label Mar 26, 2021
@connor4312 connor4312 mentioned this issue Mar 26, 2021
Closed
@JacksonKearl
Copy link
Author

It's "smart"

@connor4312 connor4312 removed the info-needed Issue requires more information from poster label Mar 31, 2021
@connor4312 connor4312 added this to the April 2021 milestone Mar 31, 2021
@RMacfarlane RMacfarlane added the verified Verification succeeded label Apr 30, 2021
@RMacfarlane
Copy link

I'm seeing a similar notification on startup when debug.javascript.autoAttachFilter is set to "smart":
Screen Shot 2021-04-30 at 9 20 34 AM

@RMacfarlane RMacfarlane reopened this Apr 30, 2021
@RMacfarlane RMacfarlane added verification-found Issue verification failed and removed verified Verification succeeded labels Apr 30, 2021
@connor4312
Copy link
Member

connor4312 commented Apr 30, 2021 •
edited
Loading

@RMacfarlane that's by design. The bug was that we showed a less helpful message (the generic debug message). Instead we want to show that specific message for auto attach.

@RMacfarlane RMacfarlane added verified Verification succeeded and removed verification-found Issue verification failed labels Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connor4312 connor4312

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
April 2021
Development

No branches or pull requests
3 participants
@connor4312 @RMacfarlane @JacksonKearl