Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote widget source provider doesn't work if any security required #10060

Closed
rchiodo opened this issue May 18, 2022 · 3 comments
Closed

Remote widget source provider doesn't work if any security required #10060

rchiodo opened this issue May 18, 2022 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug ipywidgets Rendering, loading, saving, anything to do with IPyWidgets upstream-vscode Blocked on upstream VS code verified Verification succeeded
Milestone

Comments

@rchiodo
Copy link
Contributor

rchiodo commented May 18, 2022

  1. Remove the CDN sources (make them blank)
  2. Connect to a remote server
  3. Run something that needs a widget
  4. Widget won't be downloaded

Root cause is the remote cdn provider doesn't do anything except pass the URI up to the webview for downloading. This doesn't work because the webview doesn't have the auth headers (or token) to make a valid request.

I think the solution here is to refactor the CDN downloading code to support the server as a CDN source, but then it would make the appropriate requests with the correct headers, download from the remote jupyter server, and copy the source files to the same spot it does for CDNs.

Essentially remove this source provider and have the CDN code also try kernel's baseURL. Meaning the kernel's base URL is always another CDN source.

@rchiodo rchiodo added the bug Issue identified by VS Code Team member as probable bug label May 18, 2022
@github-actions github-actions bot added the triage-needed Issue needs to be triaged label May 18, 2022
@DonJayamanne DonJayamanne added upstream-vscode Blocked on upstream VS code ipywidgets Rendering, loading, saving, anything to do with IPyWidgets iteration-candidate labels May 19, 2022
@DonJayamanne
Copy link
Contributor

Upstream issue microsoft/vscode#149868

@DonJayamanne
Copy link
Contributor

I believe this is now fixed. marking as closed so it get validated.

@rchiodo
Copy link
Contributor Author

rchiodo commented Jun 30, 2022

This is not fixed for me at least. Same result as this issue that I just reopened #10510

I did this:

  • Set "jupyter.widgetScriptSources": [],
  • Connected to a remote server
  • Ran something with a widget

I get this dialog three times in a row:

image

Then this pops up in the bottom right:

image

Restarting the kernel does NOT make the widget appear.

I also thought we weren't supposed to need the CDN on remote? It should be able to pull the js files from the nbextension folder, right?

@rchiodo rchiodo reopened this Jun 30, 2022
@rchiodo rchiodo added the verification-found Issue verification failed label Jun 30, 2022
@github-actions github-actions bot added the triage-needed Issue needs to be triaged label Jun 30, 2022
@DonJayamanne DonJayamanne removed the triage-needed Issue needs to be triaged label Jun 30, 2022
@rchiodo rchiodo modified the milestones: June 2022, July 2022 Jul 1, 2022
@DonJayamanne DonJayamanne modified the milestones: July 2022, June 2022 Jul 3, 2022
@amunger amunger removed the verification-found Issue verification failed label Jul 5, 2022
@amunger amunger added the verified Verification succeeded label Jul 5, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug ipywidgets Rendering, loading, saving, anything to do with IPyWidgets upstream-vscode Blocked on upstream VS code verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants