-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote widget source provider doesn't work if any security required #10060
Comments
Upstream issue microsoft/vscode#149868 |
I believe this is now fixed. marking as closed so it get validated. |
This is not fixed for me at least. Same result as this issue that I just reopened #10510 I did this:
I get this dialog three times in a row: Then this pops up in the bottom right: Restarting the kernel does NOT make the widget appear. I also thought we weren't supposed to need the CDN on remote? It should be able to pull the js files from the nbextension folder, right? |
Root cause is the remote cdn provider doesn't do anything except pass the URI up to the webview for downloading. This doesn't work because the webview doesn't have the auth headers (or token) to make a valid request.
I think the solution here is to refactor the CDN downloading code to support the server as a CDN source, but then it would make the appropriate requests with the correct headers, download from the remote jupyter server, and copy the source files to the same spot it does for CDNs.
Essentially remove this source provider and have the CDN code also try kernel's baseURL. Meaning the kernel's base URL is always another CDN source.
The text was updated successfully, but these errors were encountered: