-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isomorphic IInstaller: Support installing dependencies with the debugger #10605
Comments
I think we can avoid reverse engineering anything here.
Basically I think we can make this work easily today with very little changes. |
Not sure how this would work in remote or web. |
In that case we have the kernel, and we can use the kernel. |
Not while debugging. Still need to eval something. Hence the idea to figure out what %conda or %pip do, as that's what we'd eval. |
When debugging the only time we don't know IKernel is when the user laucnhes the debugger, and that point we can call Hence we always have an IKernel except in local cases when user starts a debug session for python files using python extension. Perhaps we can discuss in standup. |
Even with an IKernel, if you're debugging a cell or debugging the IW, you can't use the kernel to do the install. It's frozen. So you need to eval some code from the debugger. Maybe we just skip installing when debugging then. Although I think the install magics wouldn't be very hard to call: |
Aah yes, you're right, forgot about that one (thought that only applies to debugging |
Closing on favor of: #10638 |
With PR: #10604 we realized that to have an isomorphic dependency installer we will need to use the
debugger
.We have a dependency installer that has a nicer user experience, which is the
IInstaller
. If we were to implement an isomorphic installer, we would both use thedebugger
andIInstaller
.An important point to consider is that the code below does not work with the debugger:
To correctly implement the isomorphic installer, we might need to study how
%pip
and%conda
are implemented on Jupyter.The text was updated successfully, but these errors were encountered: