Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive window intellisense needs a middleware piece #10630

Closed
rchiodo opened this issue Jun 29, 2022 · 2 comments
Closed

Interactive window intellisense needs a middleware piece #10630

rchiodo opened this issue Jun 29, 2022 · 2 comments
Assignees
Labels
debt Code quality issues
Milestone

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Jun 29, 2022

The input box in the IW is not really a standalone document. In order for pylance to not have to code logic for the IW, we should treat the IW input box just like another cell as far as pylance (or jedi) is concerned.

This would mean intercepting the notebook related messages for the IW cells and adding the IW input box into the list of cells it expects (and possibly remapping the URI so pylance treats it like a notebook cell).

This is a stopgap measure until the core can treat the IW as an entire notebook and has an api for dealing with the IW. At that point it would just treat the input box as another cell (at least that's the suggestion right now).

@rchiodo rchiodo added the bug Issue identified by VS Code Team member as probable bug label Jun 29, 2022
@github-actions github-actions bot added the triage-needed Issue needs to be triaged label Jun 29, 2022
@rchiodo
Copy link
Contributor Author

rchiodo commented Jun 29, 2022

See this issue in pylance:
microsoft/pylance-release#2894

The current solution was to understand IW cells in pylance. Seems like the wrong place for this knowledge to exist.

@debonte
Copy link
Contributor

debonte commented Aug 9, 2022

This is complete (see the 3 PRs linked above) and available for use if you have the latest release builds of Jupyter, Python, and Pylance.

@debonte debonte closed this as completed Aug 9, 2022
@debonte debonte self-assigned this Aug 9, 2022
@DonJayamanne DonJayamanne added debt Code quality issues and removed bug Issue identified by VS Code Team member as probable bug labels Aug 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues
Projects
None yet
Development

No branches or pull requests

3 participants