Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include jQuery into nbcontroller for widgets to work #10660

Closed
DonJayamanne opened this issue Jun 30, 2022 · 1 comment
Closed

Include jQuery into nbcontroller for widgets to work #10660

DonJayamanne opened this issue Jun 30, 2022 · 1 comment
Assignees
@DonJayamanne
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues ipywidgets Rendering, loading, saving, anything to do with IPyWidgets verified Verification succeeded
Milestone
June 2022

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Jun 30, 2022 •
edited
Loading

Some widgets require jquery to work.
Jupyter lab & notebooks ship this and load it into the window.

I think we should just include it as widget expect this to be available as its an environment we need to setup, just like requirejs needs to be available.
@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Jun 30, 2022
@github-actions github-actions bot added the triage-needed Issue needs to be triaged label Jun 30, 2022
@DonJayamanne DonJayamanne added debt Code quality issues ipywidgets Rendering, loading, saving, anything to do with IPyWidgets and removed triage-needed Issue needs to be triaged labels Jul 1, 2022
@DonJayamanne DonJayamanne self-assigned this Jul 1, 2022
@DonJayamanne DonJayamanne mentioned this issue Jul 3, 2022
Merged
@DonJayamanne DonJayamanne added the verified Verification succeeded label Jul 6, 2022
@DonJayamanne
Copy link
Contributor Author

Was verified as part of testing #8241

@DonJayamanne DonJayamanne added this to the June 2022 milestone Jul 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues ipywidgets Rendering, loading, saving, anything to do with IPyWidgets verified Verification succeeded
Projects
None yet
Milestone
June 2022
Development

No branches or pull requests
1 participant
@DonJayamanne