Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Viewer: open the same variable from variable doesn't reuse Data Viewer #10942

Closed
rebornix opened this issue Jul 26, 2022 · 3 comments · Fixed by #10967
Closed

Data Viewer: open the same variable from variable doesn't reuse Data Viewer #10942

rebornix opened this issue Jul 26, 2022 · 3 comments · Fixed by #10967
Assignees
Labels
triage-needed Issue needs to be triaged

Comments

@rebornix
Copy link
Member

Testing #10915

  • Click on the action "Show Variable in Data Viewer" from the variable view
  • Data Viewer opened
  • Click again
  • It opens a new data viewer, instead of focusing on the Data Viewer again
@github-actions github-actions bot added the triage-needed Issue needs to be triaged label Jul 26, 2022
@rchiodo
Copy link
Contributor

rchiodo commented Jul 26, 2022

I believe this is on purpose too. Has to do with auto refresh. You want the state of the dataframe before and after.

@sadasant
Copy link
Contributor

Should we close this issue?

@rebornix
Copy link
Member Author

I believe this is on purpose too. Has to do with auto refresh

Now I see the intention, we allow users to open the value of the variable in a data viewer editor, and the value can change so each time we open a new data viewer to show the latest value on button click.

If this is what we offer, the command name is ambiguous Show Variable in Data Viewer is telling me that I will have the variable opened in a data viewer, and it's linked with the kernel state and Variable Viewer. Show variable current value in Data Viewer might reflect what it really does.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
triage-needed Issue needs to be triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants