Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScenePic visualizations do not display in VS Code #11366

Closed
1 of 2 tasks
matajoh opened this issue Sep 13, 2022 · 7 comments
Closed
1 of 2 tasks

ScenePic visualizations do not display in VS Code #11366

matajoh opened this issue Sep 13, 2022 · 7 comments
Assignees
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug ipywidgets Rendering, loading, saving, anything to do with IPyWidgets upstream-vscode Blocked on upstream VS code

Comments

@matajoh
Copy link
Member

matajoh commented Sep 13, 2022

Applies To

  • Notebooks (.ipynb files)
  • Interactive Window and/or Cell Scripts (.py files with #%% markers)

What happened?

I loaded this Jupyter notebook and ran the first cell. Nothing showed up. The same cell produces a ScenePic animation when viewed in Jupyter or JupyterLab.

VS Code Version

Version: 1.71.0 (user setup) Commit: 784b0177c56c607789f9638da7b6bf3230d47a8c Date: 2022-09-01T07:36:10.600Z Electron: 19.0.12 Chromium: 102.0.5005.167 Node.js: 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0.22000 Sandboxed: No

Jupyter Extension Version

v2022.8.1002431955

Jupyter logs

info 23:1:53.761: Execute Cell 0 c:\Source\scenepic\python_examples\getting_started.ipynb
info 23:1:54.184: Cell 0 executed with state Success

Coding Language and Runtime Version

Python v3.9.13

Language Extension Version (if applicable)

v2022.14.0

Anaconda Version (if applicable)

No response

Running Jupyter locally or remotely?

Local

@matajoh matajoh added bug Issue identified by VS Code Team member as probable bug triage-needed Issue needs to be triaged labels Sep 13, 2022
@DonJayamanne DonJayamanne added ipywidgets Rendering, loading, saving, anything to do with IPyWidgets jupyter-output and removed triage-needed Issue needs to be triaged labels Sep 13, 2022
@DonJayamanne
Copy link
Contributor

DonJayamanne commented Sep 16, 2022

Made some progress, however only one output gets rendered, others still fail.
Still WIP

image
scenpic1.zip

@DonJayamanne
Copy link
Contributor

Made some more progress

Screen Shot 2022-09-16 at 13 10 39

@DonJayamanne
Copy link
Contributor

Blocked by #11218, microsoft/vscode#160965

@DonJayamanne DonJayamanne added the upstream-vscode Blocked on upstream VS code label Sep 16, 2022
@matajoh
Copy link
Member Author

matajoh commented Sep 27, 2022

Amazing progress @DonJayamanne! Thanks for looking into this. Anything I can do to help support this effort?

@DonJayamanne
Copy link
Contributor

Anything I can do to help support this effort?

Not much, however once we get this working we'll need to look into the ordering issue.
I've reported this issue here with details microsoft/scenepic#48

@matajoh
Copy link
Member Author

matajoh commented Nov 11, 2022

I've fixed the rendering issue, and at least locally everything seems to be working fine. Thanks again for your help! Does it look good to you as well with the latest version (1.0.16)?

@DonJayamanne DonJayamanne added the author-verification-requested Issues potentially verifiable by issue author label Dec 4, 2022
@DonJayamanne
Copy link
Contributor

@matajoh please could you test this at your end,

  • Please install the latest insider version of VS Code
  • Install the latest pre-release versions of the Jupyter and Python extensions

Optionally wait for the new versions to be relased some time this week.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug ipywidgets Rendering, loading, saving, anything to do with IPyWidgets upstream-vscode Blocked on upstream VS code
Projects
None yet
Development

No branches or pull requests

3 participants