Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter Notebook Don't save automatically even on autosave after delay enabled #1265

Closed
goyal-aman opened this issue Jun 15, 2020 · 4 comments

Comments

@goyal-aman
Copy link

Issue Type: Bug

Create a new jupyter notebook (using ctrl+shift+p and select create new jupyter notebook), startworking on it but new changes made on the notebook are not saved. Though I expect it to be saved. But If I close and reopen the notebook it works fine.

PS : I cannot be sure if its python extention issue of Vscode.

Extension version: 2020.5.86806
VS Code version: Code 1.45.1 (5763d909d5f12fe19f215cbfdd29a91c0fa9208a, 2020-05-14T08:27:35.169Z)
OS version: Windows_NT x64 10.0.19041

System Info
Item Value
CPUs Intel(R) Core(TM) i5-8250U CPU @ 1.60GHz (8 x 1800)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: enabled
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 7.88GB (1.25GB free)
Process Argv
Screen Reader no
VM 0%
@IanMatthewHuff
Copy link
Member

@goyal-aman . Just to confirm (this is what I'm seeing when I try to repro this):

  1. Turn autosave to "afterDelay"
  2. Create a new blank notebook
  3. Save the notebook
  4. Type in the notebook some
  5. At this point the file is not saved after typing and is still dirty
  6. Close the file
  7. Reopen the file
  8. Type in the notebook some
  9. At this point the file is saved after typing and is not dirty

Is that what you are seeing as well? Looks like after creating a new notebook that autosave doesn't work until the file is saved and reopened.

@goyal-aman
Copy link
Author

goyal-aman commented Jun 18, 2020

Exactly. Autosave after delay doesn't save newly created blank notebook until closed and reopened.

@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 13, 2020
@greazer greazer added the P2 label Nov 14, 2020
@momvart
Copy link

momvart commented Nov 16, 2020

Also not working in 'onFocusChange' mode. Really annoying when you close vscode and you open it and see that your notebook is not saved automatically and a lot of work is gone.

@greazer
Copy link
Member

greazer commented Jun 6, 2021

Thanks for your feedback. This issue will be addressed once VS Code adds native support for editing notebooks. Please see microsoft/vscode#91987. You can experiment by using VS Code insiders, which defaults to the new notebook experience.

@greazer greazer closed this as completed Jun 6, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants