Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current table layout in variable viewer is clunky to navigate for screen readers #13003

Closed
amunger opened this issue Mar 6, 2023 · 1 comment
Closed

Current table layout in variable viewer is clunky to navigate for screen readers #13003

amunger opened this issue Mar 6, 2023 · 1 comment
Assignees
@amunger
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality variable-explorer

Comments

@amunger
Copy link
Contributor

amunger commented Mar 6, 2023 •
edited
Loading

Swapping out the implementation for a tree view would be a solution to this, as the tree view is built to be accessible, but perhaps we can make some quick improvements to the current implementation.

Use an HTML table with proper <TH> and <TD> entries - HTML tables provide a lot of a11y features out of the box over the current implementation with <div>s.
Since the table react, it may not be straightforward to make this switch, so improving the aria-labels might also help.
@amunger amunger added variable-explorer accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Mar 6, 2023
@meganrogge meganrogge added the feature-request Request for new features or functionality label Dec 6, 2023
@DonJayamanne DonJayamanne assigned amunger and unassigned roblourens and meganrogge Dec 13, 2023
@amunger
Copy link
Contributor Author

amunger commented Dec 13, 2023

built-in view will be accessible microsoft/vscode#165445

@amunger amunger closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@amunger amunger

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality variable-explorer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@roblourens @amunger @meganrogge