Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of URI and ServerId as identifier for Jupyter Servers #13632

Closed
4 tasks done
Tracked by #12832
DonJayamanne opened this issue Jun 2, 2023 · 0 comments · Fixed by #13956
Closed
4 tasks done
Tracked by #12832

Remove usage of URI and ServerId as identifier for Jupyter Servers #13632

DonJayamanne opened this issue Jun 2, 2023 · 0 comments · Fixed by #13956
Assignees
Milestone

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Jun 2, 2023

  • The term Uri is used in a number of places to point to the address of the Jupyter Server as well as an identifyer for a Jupyter Server.
    • Without inspecting the Uri we have no idea what it is, hence we have if conditions in a number of places
    • Unfortunately there are places where this if condition isn't used and has caused bugs (password storage and connection)
    • Error messages and the like assume the Url is the Jupyter Server Uri, but its not.
    • Basically its just too complex
  • The Uri is constructed from the Jupyter Provider Id and Handle, however without the extensionId it is not unique.
    • Its possible to have two extensions with the same provider id, and this can cause issues when we try to connect to them.
  • The Uri is constructed from the Jupyter Provider Id and Handle
    • Hence Uri is kind of always unique (provided we include the extension id into the mix)
    • Thus we do not need computeServerId
    • We have serverId used as identifiers in a number of places, along with this Uri as well
    • We have two types of identifiers

Tasks

@DonJayamanne DonJayamanne changed the title The ServerId and Remote URLs (cotaining Publisher id and handle) can be collapsed into a single Object Remove usage of URI and ServerId as identifier for Jupyter Servers Jun 12, 2023
@DonJayamanne DonJayamanne added this to the July 2023 milestone Jun 28, 2023
@DonJayamanne DonJayamanne self-assigned this Jun 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant