Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore variable viewer support for mimetype/datatypes #14315

Open
rebornix opened this issue Sep 12, 2023 · 4 comments
Open

Explore variable viewer support for mimetype/datatypes #14315

rebornix opened this issue Sep 12, 2023 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality

Comments

@rebornix
Copy link
Member

No description provided.

@rebornix rebornix added the feature-request Request for new features or functionality label Sep 12, 2023
@rebornix rebornix self-assigned this Sep 12, 2023
@rebornix rebornix added this to the September 2023 milestone Sep 12, 2023
@contang0
Copy link

Dtale is easily the best. Would be awesome to see it embedded in VS code

https://github.com/man-group/dtale

@rebornix rebornix modified the milestones: September 2023, October 2023 Sep 27, 2023
@rebornix rebornix changed the title Explore extension recommendation for pandas dataframes viewers Explore extension recommendation for mimetype/datatypes Oct 12, 2023
@rebornix rebornix changed the title Explore extension recommendation for mimetype/datatypes Explore variable viewer for mimetype/datatypes Oct 21, 2023
@rebornix rebornix changed the title Explore variable viewer for mimetype/datatypes Explore variable viewer support for mimetype/datatypes Oct 21, 2023
@rebornix
Copy link
Member Author

With the latest changes from #14545, we now allow 3rd party data viewers to specify which data types they support, and this will determine whether or not an Open button is displayed in the variable viewer row. If there are multiple data viewers for the same data type, a quick pick will appear and ask the user to select the data viewer they prefer.

We can also display a tooltip for data types that don't have data viewers available, with a tooltip that says "No installed extension can view this data type. Click here to find recommended extensions". However, since we are exploring a native variable explorer in the VS Code core, this is not implemented in the variable explorer shipped with Jupyter.

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Oct 23, 2023

@rebornix Not sure this is ready to be exposed to 3rd parties just yet
Some points we might want to look at

  • The argument passed into the command is IJUpyterVariable, seems to be very complex (I would have expected we need to just provide the name and the type)
  • If someone else is consuming this, wouldn't they need access to the API to get the details of the variable?

I.e. shouldn't the arguments passed into the command (thus passed into 3rd party extension) go through a general API review/discussion?
Saying this as I do not like the current shape of the argument IJupyterVariable

@rebornix
Copy link
Member Author

The argument passed into the command is IJUpyterVariable, seems to be very complex (I would have expected we need to just provide the name and the type)
If someone else is consuming this, wouldn't they need access to the API to get the details of the variable?

@DonJayamanne good catch and I fully agree. Using IJupyterVariable is intermediate and most of the properties on it are not needed.

shouldn't the arguments passed into the command (thus passed into 3rd party extension) go through a general API review/discussion?

Yep, if we are finalizing it, we go through API reviews. Also to fully build a data viewer extension, the Kernel API is needed, I'll bring this up when we are building the new Kernel API.

@rebornix rebornix modified the milestones: October 2023, November 2023 Oct 24, 2023
@rebornix rebornix modified the milestones: November 2023, December 2023 Nov 30, 2023
@joaomoreno joaomoreno removed this from the December 2023 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

4 participants