Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop jupyter.notebookeditor.collapseallcells and similar duplicate commands and remove code that updates metadata #15396

Closed
DonJayamanne opened this issue Mar 19, 2024 · 1 comment · Fixed by #15482
Assignees
Labels
debt Code quality issues notebook-commands
Milestone

Comments

@DonJayamanne
Copy link
Contributor

  • These commands already exist in Core, as a result these commands are not necessary
  • The metadata changes are incorrect & unnecessary
  • The commands are already not displayed due to an invalid when clause

The last item is reason enough to remove this entirely

@DonJayamanne DonJayamanne added debt Code quality issues notebook-commands labels Mar 19, 2024
@DonJayamanne DonJayamanne self-assigned this Mar 19, 2024
@DonJayamanne
Copy link
Contributor Author

Similarly review other commands in notebookCommandListener

@DonJayamanne DonJayamanne added this to the April 2024 milestone Apr 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues notebook-commands
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant