Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use background thread on kernel to gather variable information #15485

Closed
amunger opened this issue Apr 3, 2024 · 2 comments · Fixed by #15495
Closed

use background thread on kernel to gather variable information #15485

amunger opened this issue Apr 3, 2024 · 2 comments · Fixed by #15495
Assignees
Labels
debt Code quality issues variable-explorer

Comments

@amunger
Copy link
Contributor

amunger commented Apr 3, 2024

example: https://insiders.vscode.dev/github.com/microsoft/vscode-jupyter/blob/main/src/standalone/chat/extesnion.ts#L82-L100

@amunger amunger added variable-explorer debt Code quality issues labels Apr 3, 2024
@amunger amunger self-assigned this Apr 3, 2024
@amunger
Copy link
Contributor Author

amunger commented Apr 4, 2024

@DonJayamanne can you help me with a couple questions:

  • Our namespaced built-ins aren't available in the scope of the bg thread, does that mean that normal built-ins are ok to use?
  • "../../standalone/api/kernels/backgroundExecution" imported in restricted zone. Only modules from ./src/platform and ./src/telemetry can be imported into ./src/kernels.
    • can we move this hleper into platform?

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Apr 4, 2024

Yes to both,
Though I'm not sure why first isn't working. it should
Perhaps its the way the python code is structured,
If i recall correctly we to send multiple requests (the first few setup the namesapces and global functions),
instead of sending multiple requests, we might want to send one single request,
Else a function created in one request might not be available to the other request (after all the scope is different as each run in a function scope in different threads).

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues variable-explorer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants