Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ruff instead of black in CI lint check #16030

Open
amunger opened this issue Sep 10, 2024 · 1 comment · May be fixed by #16161
Open

use ruff instead of black in CI lint check #16030

amunger opened this issue Sep 10, 2024 · 1 comment · May be fixed by #16161
Assignees
Labels
debt Code quality issues
Milestone

Comments

@amunger
Copy link
Contributor

amunger commented Sep 10, 2024

we now recommend using Ruff and removed the recommendation of black, but still format the files with black (although black is still mentioned in contributing.md). Could we switch the lint check to use RUFF instead and remove our dependence from black entirely?

@amunger amunger added bug Issue identified by VS Code Team member as probable bug debt Code quality issues labels Sep 10, 2024
@amunger
Copy link
Contributor Author

amunger commented Sep 10, 2024

python extension also mentions black in their configuration guide https://github.com/microsoft/vscode-python/wiki/Coding#building, but seems like that might just be out of date. cc @karthiknadig

@DonJayamanne DonJayamanne removed the bug Issue identified by VS Code Team member as probable bug label Sep 10, 2024
@DonJayamanne DonJayamanne added this to the November 2024 milestone Oct 28, 2024
@DonJayamanne DonJayamanne linked a pull request Oct 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants