Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to detect kernel API permission errors #16074

Closed
pwang347 opened this issue Sep 25, 2024 · 1 comment · Fixed by #16083
Closed

Ability to detect kernel API permission errors #16074

pwang347 opened this issue Sep 25, 2024 · 1 comment · Fixed by #16083
Assignees
@DonJayamanne
Labels
api-proposal notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) partner
Milestone
October 2024

Comments

@pwang347
Copy link
Member

Hi there,

Currently the access errors are being localized, e.g., https://github.com/microsoft/vscode-jupyter/blob/main/src/standalone/api/kernels/kernel.ts#L287. This means that we don't have a reliable way to detect when issues with kernel execution are due to permission errors like this to display a more appropriate message.

It would be great if we could have a reliable method to detect this. Thanks!

Related: microsoft/vscode-data-wrangler#270
@pwang347 pwang347 added the feature-request Request for new features or functionality label Sep 25, 2024
@DonJayamanne
Copy link
Contributor

Solution

If the name property of the error is vscode.jupyter.apiAccessRevoked then this means the access to the API has been revoked.

@DonJayamanne DonJayamanne mentioned this issue Sep 30, 2024
Merged
@DonJayamanne DonJayamanne added this to the October 2024 milestone Sep 30, 2024
@DonJayamanne DonJayamanne added partner notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) api-proposal labels Sep 30, 2024
@DonJayamanne DonJayamanne removed the feature-request Request for new features or functionality label Oct 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
api-proposal notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) partner
Projects
None yet
Milestone
October 2024
Development

Successfully merging a pull request may close this issue.

Throw custom err when kernel API access is revoked microsoft/vscode-jupyter
2 participants
@DonJayamanne @pwang347