Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated completion items #16173

Closed
2 tasks done
heejaechang opened this issue Oct 29, 2024 · 9 comments · Fixed by #16176 or #16286
Closed
2 tasks done

Duplicated completion items #16173

heejaechang opened this issue Oct 29, 2024 · 9 comments · Fixed by #16176 or #16286
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook-intellisense Intellisense & other language features in notebook cells for any language
Milestone

Comments

@heejaechang
Copy link
Contributor

heejaechang commented Oct 29, 2024

Applies To

  • Notebooks (.ipynb files)
  • Interactive Window and/or Cell Scripts (.py files with #%% markers)

What happened?

Image

repro steps

  1. create a cell
  2. type import os
  3. run the cell
  4. create a cell after the first cell
  5. type os. <= completion here

repro for both notebook and interactive window

VS Code Version

1.94.2

Jupyter Extension Version

v2024.10.2024100401

Jupyter logs

No response

Coding Language and Runtime Version

No response

Language Extension Version (if applicable)

No response

Anaconda Version (if applicable)

No response

Running Jupyter locally or remotely?

None

@heejaechang heejaechang added the bug Issue identified by VS Code Team member as probable bug label Oct 29, 2024
@DonJayamanne

This comment has been minimized.

@DonJayamanne DonJayamanne added info-needed Issue requires more information from poster notebook-intellisense Intellisense & other language features in notebook cells for any language labels Oct 29, 2024
@DonJayamanne DonJayamanne added this to the November 2024 milestone Oct 29, 2024
@DonJayamanne DonJayamanne removed the info-needed Issue requires more information from poster label Oct 29, 2024
@GF-Huang
Copy link

@rchiodo Is it fixed in v2024.11.2?

@rchiodo
Copy link
Contributor

rchiodo commented Nov 18, 2024

The fix for this wouldn't be in Pylance. It would be in the jupyter extension. Given that Don submitted a fix 3 weeks ago, I suspect the latest Jupyter prerelease has the fix in it.

@GF-Huang
Copy link

GF-Huang commented Nov 19, 2024

I tried the Jupyter v2024.11.2024102401 (pre-release), issue still.

@rchiodo
Copy link
Contributor

rchiodo commented Nov 19, 2024

I'm using 2024.11.2024111901 and it doesn't seem to repro for me:

Image

@GF-Huang
Copy link

GF-Huang commented Nov 19, 2024

@rchiodo I found it depends on Python version, I can reproduce on 3.10.12, could you try it?

And, I can't find 2024.11.2024111901, how did you do that?

Image

@rchiodo
Copy link
Contributor

rchiodo commented Nov 19, 2024

You might be on VS code stable. I'm using VS code insiders. Jupyter may have updated their required VS code version so the latest only works on insiders.

I can repro with Python 3.10 too:

Image

@DonJayamanne you may need something different based on the results returned from ipykernel. Older versions must have had different completions.

@rchiodo rchiodo reopened this Nov 19, 2024
@DonJayamanne
Copy link
Contributor

Steps to repro

  • Install Python 3.10
  • Install pylance
  • Install the latest version of ipykernel
  • Run a cell containing the text import os
  • In the next cell type the text os.path.abs at this point we should get completions for abspath and there should be just one item, instead of two.

@DonJayamanne
Copy link
Contributor

@rchiodo Found that the label * abspath is what was causing the issue, I.e. the prefix *
Hopefully the new fix should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug notebook-intellisense Intellisense & other language features in notebook cells for any language
Projects
None yet
4 participants