Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support customizing Just My Code settings for interactive window #1656

Closed
Coderx7 opened this issue Jan 21, 2020 · 5 comments
Closed

Support customizing Just My Code settings for interactive window #1656

Coderx7 opened this issue Jan 21, 2020 · 5 comments
Labels
interactive-window Impacts interactive window

Comments

@Coderx7
Copy link

Coderx7 commented Jan 21, 2020

Feature: Notebook Editor, Interactive Window, Python Editor cells

Description

It would be great, not to encounter the interactiveshell.py when debugging.
I uncheck Debug just my code so that I can step into the libraries I use. However, interactiveshell.py is a nuisance here which I really dont need to see or work with.
If interactiveshell.py is of any importance, we can add a separate checkmark for it in the settings that lets the user explicitly enable it (i.e. when debugging, the first code that he/she sees is interactiveshell.py!).
In my humble opinion, 99.99% of the times, no one intends on checking on interactiveshell.py when they start debugging their code.
It would be great to have this out of the way.
Thank you all very much in advance

Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer

@Coderx7 Coderx7 changed the title Please Do not step into interactiveshell.py in cell debuging when debug my code is unchecked Please Do not step into interactiveshell.py in cell debuging when Debug just my code is unchecked Jan 21, 2020
@IanMatthewHuff
Copy link
Member

@Coderx7 . Thanks for the report. I don't think that we would special case one item. Instead we should be respecting the general ptvsd debugging rules:
microsoft/ptvsd#997
We'll take a look to see if we are respecting these in cell debugging, not sure if we currently are or not.

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Jan 21, 2020

Possibly resolved by #2087 (allowing a more fine grained solution)
At this stage interactiveshell.py is not considered part of just my code i.e. not user code, hence debugger will step in there.
Closing this as this is by design. @IanMatthewHuff /cc

Missed this not sure if we currently are or not.

@greazer
Copy link
Member

greazer commented Jan 23, 2020

We are dependent on #2087 being addressed before being able to do this.

@greazer
Copy link
Member

greazer commented Mar 9, 2020

New link to dependent issue is: https://github.com/microsoft/ptvsd/issues/2073

@greazer greazer closed this as completed Mar 9, 2020
@greazer greazer reopened this Mar 9, 2020
@greazer greazer changed the title Please Do not step into interactiveshell.py in cell debuging when Debug just my code is unchecked Support customizing Just My Code settings for interactive windowdebuging when Debug just my code is unchecked Jul 16, 2020
@greazer greazer changed the title Support customizing Just My Code settings for interactive windowdebuging when Debug just my code is unchecked Support customizing Just My Code settings for interactive window Jul 16, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 13, 2020
@greazer greazer added the interactive-window Impacts interactive window label Jul 30, 2021
@joyceerhl
Copy link
Contributor

This should be fixed with microsoft/debugpy#664

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
interactive-window Impacts interactive window
Projects
None yet
Development

No branches or pull requests

5 participants