Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use activated environment to check if module is installed #2416

Closed
DonJayamanne opened this issue Jan 17, 2020 · 1 comment
Closed

Use activated environment to check if module is installed #2416

DonJayamanne opened this issue Jan 17, 2020 · 1 comment
Assignees
@DonJayamanne

Comments

@DonJayamanne
Copy link
Contributor

Currently we're not using an activated environment process to check if a module is installed, similarly when installing ipykernel.

Could be the cause of https://github.com/microsoft/vscode-python/issues/9638 and https://github.com/microsoft/vscode-python/issues/9566
@DonJayamanne DonJayamanne self-assigned this Jan 17, 2020
DonJayamanne referenced this issue in microsoft/vscode-python Jan 17, 2020
@DonJayamanne
Use activated python proc to check if modules are installed (#9644)
97bad7d 
For #9643
* Use activated python proc to check if modules are installed
* Fixes to use python environment correctly
* Fixes
* Fix tests
* Add news entry
* Oops
@rchiodo
Copy link
Contributor

rchiodo commented Jan 21, 2020

Validated. At least it works, not sure if it fixes the two issues mentioned or not though as I never repro'd them.

@rchiodo rchiodo closed this as completed Jan 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2020
@microsoft microsoft unlocked this conversation Nov 13, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 13, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DonJayamanne @rchiodo