Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we use the new Trusted notebook icon #4338

Closed
DonJayamanne opened this issue Jan 11, 2021 · 4 comments
Closed

Ensure we use the new Trusted notebook icon #4338

DonJayamanne opened this issue Jan 11, 2021 · 4 comments
Assignees
@DonJayamanne @DavidKutu
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@DonJayamanne
Copy link
Contributor

TODO: Don find the icons
@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Jan 11, 2021
@DonJayamanne DonJayamanne modified the milestone: parit Jan 11, 2021
@DavidKutu
Copy link

use blocked site and encryption

@DavidKutu DavidKutu self-assigned this Jan 20, 2021
@DavidKutu DavidKutu mentioned this issue Jan 20, 2021
Merged
9 tasks
@DonJayamanne
Copy link
Contributor Author

DonJayamanne commented Jan 22, 2021 •
edited
Loading

Validated. However moving back to backlog so that we move the icon to the far right.
This way its a non-introsive icon, right now this is in beween the move cells & maginify icons.

My suggestion is to move it to the faar right, right not its in the middle of other icons & this will never be used.
See below what it looks like.

@claudiaregio if this isn't required, then please feel free to close this issue as resolved.
I.e. adding an icon that does nothing in between that do, seem weird, might as well move this to the far right.

Screen Shot 2021-01-22 at 15.32.43.png

@DonJayamanne DonJayamanne self-assigned this Jan 23, 2021
@claudiaregio
Copy link
Contributor

@DonJayamanne Please make sure it is moved all the way to the right

@rchiodo
Copy link
Contributor

rchiodo commented Jan 25, 2021

Validated

@rchiodo rchiodo closed this as completed Jan 25, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

@DavidKutu DavidKutu

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@DonJayamanne @claudiaregio @rchiodo @DavidKutu