You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
CellExecution and JupyterNotebook should be combined into a more generic algorithm (this is really jupyter exceution)
jupyterNotebook.ts should probably be renamed? That's where we handle IO pub messages, and I always have to dig around for that file when trying to debug kernel messages
Break INotebook into smaller components (componetise):
Separate class to communicate with kernel
Separate class to get active kernel & status of kernel & the like
Separate class to execute & manage execution state
Separate class to manage starting kernels
JupyterNotebook should be split into multiple parts. Exposing the kernel, exposing the session, and execution. Exposing the kernel by itself would make the execution part easy to do alone
Our initial "mega-classes" like INotebook Session are too big and expose too much.
Break large classes into smaller components.
Composition over inheritance & composition over god classes.
Having one class that does everything makes it difficult to extend & re-purpose
The text was updated successfully, but these errors were encountered:
Work Item
Split JupyterNotebook into separate classes
Determine if Live share is used or not
Original Complaint:
from here (http://pyretro.westus.azurecontainer.io:4000/#3b9f321e-9838-486e-a661-a5e96c46189f)
CellExecution and JupyterNotebook should be combined into a more generic algorithm (this is really jupyter exceution)
jupyterNotebook.ts should probably be renamed? That's where we handle IO pub messages, and I always have to dig around for that file when trying to debug kernel messages
Break INotebook into smaller components (componetise):
JupyterNotebook should be split into multiple parts. Exposing the kernel, exposing the session, and execution. Exposing the kernel by itself would make the execution part easy to do alone
Our initial "mega-classes" like INotebook Session are too big and expose too much.
Break large classes into smaller components.
Composition over inheritance & composition over god classes.
Having one class that does everything makes it difficult to extend & re-purpose
The text was updated successfully, but these errors were encountered: