Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data viewer should clearly indicate when data is filtered #4462

Closed
joyceerhl opened this issue Jan 22, 2021 · 2 comments
Closed

Data viewer should clearly indicate when data is filtered #4462

joyceerhl opened this issue Jan 22, 2021 · 2 comments

Comments

@joyceerhl
Copy link
Contributor

Originally from #1286 (comment):

One thing on filtering pandas dataframes:
I can click on Filter Rows button and enter a condition in any of the white boxes that appear below the column names. The dataframe gets filtered in real time. But when I click again on teh Filter Rows button, the dataframe stays filtered. I'd expect that once the filters are masked, they are not applied. One could get confused unless he shows the filters.
My suggestion is that the filters gets applied only when the conditions are visible or, alternatively, add some indication that the dataframe is filtered even when the conditions are hidden.

@joyceerhl
Copy link
Contributor Author

We added a clear filter button in #4805. Not sure if that addresses the ask here.

@IanMatthewHuff
Copy link
Member

With the "clear filters" button and having to explicitly pick "hide filters" this feels resolved to me unless customers complain.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants