Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbconvert can sometimes not be found, we should install it next to the extension like ipykernel #450

Closed
Tracked by #1122
rchiodo opened this issue Sep 16, 2020 · 8 comments
Labels
feature-request Request for new features or functionality notebook-import-export

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Sep 16, 2020

No description provided.

@DonJayamanne
Copy link
Contributor

Some implications

  • For every python environment (different python versions), we'd end up installing nbconvert.
  • nbconvert is similar to jupyter, & its agnostic of the kernel & unrelated. Its basically a tool that can be used for all notebooks & all kernels. Hence I don't think we sholuld install this every time.

I still think we should install this into one place, the jupyter interpreter (single place for all tools that will work across all notebooks/kernels & python versions).

IpyKernel is slightly different. This must be installed in each kernel, where as with nbconvert, its not a must.

@DonJayamanne
Copy link
Contributor

nbconvert can sometimes not be found

Do we know when this cannot be found, i think we shoudl try to get to the bottom of that.

@rchiodo
Copy link
Contributor Author

rchiodo commented Sep 17, 2020

User didn't install full jupyter is the most obvious scenario.

@DonJayamanne
Copy link
Contributor

User didn't install full jupyter is the most obvious scenario.

Can't we solve this by then checking if jupyter is also installed when checking for nbconvert?

@rchiodo
Copy link
Contributor Author

rchiodo commented Sep 17, 2020

You can have jupyter without nbconvert.

@DonJayamanne
Copy link
Contributor

Yes. WHat i'm suggesting is when users install nbconvert, we also install jupyter into this single interpreter which is the jupyter interepreter.
I.e. a way to solve User didn't install full jupyter is the most obvious scenario.

@DonJayamanne
Copy link
Contributor

Oh wait I see a problem, which maybe what you're trying to hightlight.
Raw kernel users won't have a designated jupyter interpreter. Hence when users attempt to use nbconvert, then this doesn't necessarily get installed into a single location, like we do with Jupyter.

Wouldn't using a single interpreter for such tools solve the problem. I.e. use a single python intererpetrt (we call this jupyter interpreter), for all tools like nbconvert, jupyter, etc.

@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 11, 2020
@greazer greazer added this to the May 2021 Release milestone Apr 1, 2021
@greazer greazer modified the milestones: May 2021 Release, June 2021 Release Apr 22, 2021
@greazer greazer modified the milestone: July 2021 Release Jun 8, 2021
@greazer greazer added the notebook-kernel Kernels issues (start/restart/switch/execution, install ipykernel) label Aug 2, 2021
@DonJayamanne DonJayamanne added notebook-import-export and removed notebook-kernel Kernels issues (start/restart/switch/execution, install ipykernel) issue_grooming_don labels Oct 18, 2021
@greazer greazer added feature-request Request for new features or functionality and removed enhancement labels May 4, 2022
@IanMatthewHuff IanMatthewHuff removed their assignment Nov 10, 2022
@DonJayamanne
Copy link
Contributor

There haven't been any upvotes nor complaints in this space, hence closing this issue

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality notebook-import-export
Projects
None yet
Development

No branches or pull requests

4 participants