Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted Notebooks remain open in the editor #4683

Closed
david-waterworth opened this issue Feb 4, 2021 · 3 comments
Closed

Deleted Notebooks remain open in the editor #4683

david-waterworth opened this issue Feb 4, 2021 · 3 comments

Comments

@david-waterworth
Copy link

Environment data

  • VS Code version: 1.52.1
  • Extension version (available under the Extensions sidebar): v2021.1.502429796
  • OS and version: Ubuntu 20.04

Expected behaviour

Consistency when deleting files. When you delete any file in the explorer, the file is removed from the editor window.

Actual behaviour

If you delete an ipynb file in the explorer, the notebook remains open. This makes it really easy to accidentally edit the deleted file (or even run a cell) which results in it being recreated.

Steps to reproduce:

  1. Open a notebook
  2. Delete the file in explorer
@david-waterworth
Copy link
Author

david-waterworth commented Feb 5, 2021

This also occurs with rename, if I rename an open ipynb it doesn't close / reopen the original notebook.

@karthiknadig karthiknadig transferred this issue from microsoft/vscode-python Feb 5, 2021
@rchiodo
Copy link
Contributor

rchiodo commented Feb 9, 2021

Thanks for the bug.

This should be addressed when we switch over to VS code's new notebook API. Please track this issue for when we switch:
#1231.

You can try it yourself if you use VS code insiders.

@greazer
Copy link
Member

greazer commented Feb 17, 2021

Thanks for your feedback. This issue will be addressed once VS Code adds native support for editing notebooks. Please see microsoft/vscode#91987.

@greazer greazer closed this as completed Feb 17, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants