Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra data on hover is missing in old webview #5124

Closed
rchiodo opened this issue Mar 11, 2021 · 5 comments
Closed

Extra data on hover is missing in old webview #5124

rchiodo opened this issue Mar 11, 2021 · 5 comments
Assignees

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Mar 11, 2021

I have pylance and I'm using an ipynb file. This is what i see when i try to get the docstrings from a function inside a modelu.
The first one is from VS Code Insiders which works pretty fine.
Captura de pantalla (22)
Captura de pantalla (23)

Originally posted by @arribass in #4218 (comment)

@rchiodo
Copy link
Contributor Author

rchiodo commented Mar 11, 2021

I can repro too. Webview is not showing the extra data anymore. Likely another API change.

@greazer greazer added this to the April 2021 Release milestone Mar 24, 2021
@DavidKutu DavidKutu self-assigned this Mar 24, 2021
@joyceerhl
Copy link
Contributor

Hmm I'm seeing this with Pylance installed and set as python.languageServer in the custom editor:

image

Is this expected behavior @rchiodo?

@rchiodo
Copy link
Contributor Author

rchiodo commented Apr 2, 2021

No that's the bug. David's merge should have fixed it.

@DavidKutu
Copy link

DavidKutu commented Apr 5, 2021

You need to click the 'i' to get the documentation.
That's how the monaco editor behaves.

@joyceerhl
Copy link
Contributor

Thanks @DavidKutu, closing as validated:
image

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants