Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSL - jupyter notebook takes to long to open in VS Code Insiders. It's slow. loading performance #5211

Closed
Tracked by #1122
chrisdias opened this issue Mar 19, 2021 · 10 comments
Labels
bug Issue identified by VS Code Team member as probable bug notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel)

Comments

@chrisdias
Copy link
Member

Environment data

Version: 1.55.0-insider (user setup)
Commit: 111a6cec70f9562cdd31a5fd8cdea4b3a9b7bd82
Date: 2021-03-18T05:14:49.087Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Windows_NT x64 10.0.19041

  • VS Code version: XXX
  • Jupyter Extension version v2021.4.641214696
  • Python Extension version v2021.3.658691958
  • Python and/or Anaconda version: 3.8.5 64bit
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): NA
  • Jupyter server running: Local

Running WSL with Ubuntu 20.04 LTS

On first load of a simple notebook, it can take 15 - 20 seconds for the Notebook to be ready. This is consistent on every reload of the workbench.

In this video I run it 2 times to show the consistency of the timings.

recording

@chrisdias chrisdias added the bug Issue identified by VS Code Team member as probable bug label Mar 19, 2021
@DonJayamanne
Copy link
Contributor

Yikes, I think I know what's going on.
Please could you disable the python extension, we might be activating it too early. Fyi, we have a separate issue whee were trying to manage the dependency on python.

@chrisdias
Copy link
Member Author

chrisdias commented Mar 19, 2021

If I disable the python extension, its about 3-4sec to bring up the notebook, which is much more inline with how my normal setup works on my surface with remote-wsl.

I get this:

image

which seems a little weird since I can use multiple languages with Jupyter, right? This is perhaps a separate issue.

I would do a timing video but it wouldn't help since by the time I moved the mouse to start the timer it would be done :).

@DonJayamanne
Copy link
Contributor

s about 3-4sec to bring up the notebook, which is much more inline with how my normal setup works on my surface with remote-wsl.

Yup, i've figured out the cause. Thanks

which seems a little weird since I can use multiple languages with Jupyter, right? This is perhaps a separate issue.

We're tracking this in a seprate issue. and i've got some fixes for this as well.
We want to display this message only for users who open python notebooks.
If you open a julia notebook, then you shouldn't get this prompt.

@DonJayamanne
Copy link
Contributor

Notes

@greazer greazer changed the title jupyter notebook loading performance jupyter notebook takes to long to open. It's slow. loading performance Mar 22, 2021
@greazer greazer added this to the May 2021 Release milestone Apr 1, 2021
@greazer greazer changed the title jupyter notebook takes to long to open. It's slow. loading performance WSL - jupyter notebook takes to long to open. It's slow. loading performance Apr 23, 2021
@greazer
Copy link
Member

greazer commented Apr 23, 2021

This WSL scenario has been improved. There's likely more we can do here though. Moving to June for further consideration.

@greazer greazer modified the milestones: May 2021 Release, June 2021 Release Apr 23, 2021
@greazer
Copy link
Member

greazer commented Jun 4, 2021

Moving to July as we couldn't get to this for June.

@chriddyp
Copy link

Hi folks! I see this as well. Here are two GIFs for reference.

Loading for the first time - Takes ~45 seconds

jupyter-loading-2

Reloading the file the second time (I'm assuming the kernel is already running in background & extension is loaded) - ~10 seconds to open file, another 10 seconds to connect to kernel.

jupyter-loading-3

@DonJayamanne DonJayamanne changed the title WSL - jupyter notebook takes to long to open. It's slow. loading performance WSL - jupyter notebook takes to long to open in VS Code Insiders. It's slow. loading performance Jun 14, 2021
@DonJayamanne
Copy link
Contributor

@chriddyp Please could you try using VS Code Insiders. This issue focuses on the perf related to the use of the new Notebook UI when used in VS Code insiders (note this is the UI we're planning in rolling out in place of the current UI).

@chriddyp
Copy link

chriddyp commented Jun 15, 2021

Thanks for the pointer @DonJayamanne , and sorry for the noise!

Just downloaded Insiders and the performance is indeed much better. Love the new UI, too!

insiders-jupyter-loading-1

Timeline on my computer:
@1s - Jupyter Toolbar
@4s - See Jupyter Cells
@6s - Jupyter Cell is Editable
@30s - Finished Connecting to Kernel & Ran Cell

@greazer greazer modified the milestones: July 2021, August 2021 Jul 30, 2021
@greazer greazer added the notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) label Aug 2, 2021
@greazer greazer modified the milestones: August 2021, old August 2021 Aug 9, 2021
@DonJayamanne
Copy link
Contributor

Closing this issue as ipynb editor has been moved into VS Code core.
(hence there shouldn't be any more perf issues related to opening ipynb files, at least not ones contributed by the jupyter extension)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel)
Projects
None yet
Development

No branches or pull requests

4 participants